Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mounting dynamic routes. FIxes #250 #288

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Support mounting dynamic routes. FIxes #250 #288

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d6f769f
support mounting dynamic routes
davidmartos96 Sep 10, 2022
fc6a208
comment
davidmartos96 Sep 10, 2022
ebc69e4
rename variables
davidmartos96 Sep 10, 2022
73f3e28
dart format
davidmartos96 Sep 10, 2022
7d4fd13
typo
davidmartos96 Sep 10, 2022
cbb346e
support dynamic mounted routes with regexp
davidmartos96 Sep 11, 2022
07e2745
mounted dynamic routes simplification
davidmartos96 Sep 13, 2022
c1378fc
some comments
davidmartos96 Sep 13, 2022
b75065c
update docstring
davidmartos96 Sep 13, 2022
d1db074
update docstring
davidmartos96 Sep 13, 2022
1a7d4dc
don't create Routers when handling the request
davidmartos96 Sep 14, 2022
c1d4d07
lints
davidmartos96 Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
some comments
  • Loading branch information
@davidmartos96
davidmartos96 committed Sep 15, 2022
commit c1378fc647e8cec95af2b73dded8ca8360e77371
21 changes: 15 additions & 6 deletions pkgs/shelf_router/lib/src/router.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,23 +197,32 @@ class Router {
Future<Response> _invokeMountedHandler(
Request request, Function handler, List<String> pathParams) async {
final paramsMap = request.params;
final effectivePath = _replaceParamsInPath(request.url.path, paramsMap);

return await Function.apply(handler, [
request.change(path: effectivePath),
...pathParams.map((param) => paramsMap[param]),
]) as Response;
}

/// Replaces the variable slots (<someVar>) from [path] with the
/// values from [paramsMap]
String _replaceParamsInPath(
String urlPath,
Map<String, String> paramsMap,
) {
final pathParamSegment = paramsMap[_kRestPathParam];
final urlPath = request.url.path;
late final String effectivePath;
if (pathParamSegment != null && pathParamSegment.isNotEmpty) {
/// If we encounter the "rest path" parameter we remove it
/// from the request path that shelf will handle.
effectivePath =
urlPath.substring(0, urlPath.length - pathParamSegment.length);
} else {
// No parameters in the requested path
effectivePath = urlPath;
}

return await Function.apply(handler, [
request.change(path: effectivePath),
...pathParams.map((param) => paramsMap[param]),
]) as Response;
return effectivePath;
}

/// Route incoming requests to registered handlers.
Expand Down