Add configFileName templating, to provide additional controls for externally managed configMaps#34
Conversation
…path of the configMap
|
I'm still new to helm, so feedback is very much welcome |
|
To give some additional context: My use case is that I have multiple cloudprober_${environment}.cfg files, since I'm running Cloudprober both in and outside of K8s. While I could grandfather cloudprober.cfg to be the k8s config, I'd prefer to be able to call it cloudprober_k8s.cfg so it's self documenting |
* Create configFileName, which defaults to "cloudprober" * Remove cloudprober_cfg_path, it's not needed anymore
conallob
changed the title
|
Friendly ping? I lost my merge approval when I added configFileName to templates/configmap.yaml |
* Update the configMap annotation too
|
My edits to values.yaml will need additional approval. Feel free to make a maintainer edit before merging, if you disagree with my use of reasonable default values for configFileName |
manugarg
left a comment
manugarg
left a comment
There was a problem hiding this comment.
Minor comment fixes. I'll commit them.
manugarg
left a comment
manugarg
left a comment
There was a problem hiding this comment.
Couple of more that I'll commit shortly.
|
@conallob Charts version 1.13.18 will have the latest changes. |
2 participants
Add templating to allow users to define their own command line arguments, with reasonable defaults if no customisation is
defined
Add templating to allow users to control the mount path for the configMap