refactor: fix shellcheck#10508
Closed
nguyentranchung wants to merge 3 commits intochatwoot:developfrom
Closed
Conversation
|
🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild? |
|
🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild? |
scmmishra
reviewed
Jun 2, 2025
Member
scmmishra
left a comment
scmmishra
left a comment
There was a problem hiding this comment.
Hey @nguyentranchung we don't accept cosmetic changes. See: https://www.chatwoot.com/hc/handbook/articles/pull-request-guidelines-32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix shellcheck:
https://www.shellcheck.net/wiki/SC2155
https://www.shellcheck.net/wiki/SC2086
https://www.shellcheck.net/wiki/SC2116
https://www.shellcheck.net/wiki/SC2006