Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable newrelic monitoring on staging env #10433

Closed
wants to merge 1 commit into from
Closed

chore: disable newrelic monitoring on staging env #10433

wants to merge 1 commit into from

Conversation

vishnu-narayanan
Copy link
Member

@vishnu-narayanan vishnu-narayanan commented Nov 18, 2024 •
edited
Loading

Pull Request Template

Description

  • Disable newrelic monitoring in staging environments by default
  • Use NEW_RELIC_STAGING_MONITORING_ENABLED env variable to toggle this behavior if needed

Fixes https://linear.app/chatwoot/issue/CW-3724/newrelic-disable-monitoring-in-staging-env

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested in staging

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@linear Linear
Copy link

linear bot commented Nov 18, 2024

CW-3724 newrelic: disable monitoring in staging env

sojan-official
sojan-official reviewed Nov 19, 2024
View reviewed changes
config/newrelic.yml
@@ -58,6 +58,7 @@ test:
staging:
<<: *default_settings
app_name: <%= ENV.fetch('NEW_RELIC_APP_NAME', 'Chatwoot') %> (Staging)
monitor_mode: <%= ENV.fetch('NEW_RELIC_STAGING_MONITORING_ENABLED', false) %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have NEW_RELIC_MONITORING_ENABLED as the environment variable and also have this option passed in for test environment as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I will close out this PR and make the change in the original PR.

#10408

@github-actions GitHub Actions
Copy link

🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild?

@github-actions github-actions bot added the stale label Dec 21, 2024
@sojan-official
Copy link
Member

ref: #10433 (comment)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sojan-official sojan-official sojan-official left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnu-narayanan @sojan-official