Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-15091 Add Feature Flag to DB called UseRiskInsights #5088

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

voommen-livefront
Copy link
Collaborator

@voommen-livefront voommen-livefront commented Nov 26, 2024

🎟️ Tracking

📔 Objective

The purpose of this PR is:

  • To add a new database column called UseRiskInsights to dbo.Organization for all 4 supported databases (SQL server, MySql, Postgres and Sqlite)
  • To update the various procedures and views
  • To ensure that the commands and queries include the flag UseRiskInsights
  • To update the admin site to include the feature as shown in the screen shot below

📸 Screenshots

In addition to adding the backend scripts - the admin site has been changed to include UseRiskInsights flag

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.15%. Comparing base (e9297f8) to head (b5ba483).

Files with missing lines Patch % Lines
...Admin/AdminConsole/Models/OrganizationEditModel.cs 0.00% 3 Missing ⚠️
...esponse/Organizations/OrganizationResponseModel.cs 0.00% 2 Missing ⚠️
...dminConsole/Controllers/OrganizationsController.cs 0.00% 1 Missing ⚠️
...Admin/AdminConsole/Models/OrganizationViewModel.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5088   +/-   ##
=======================================
  Coverage   43.14%   43.15%           
=======================================
  Files        1424     1424           
  Lines       65094    65112   +18     
  Branches     5964     5964           
=======================================
+ Hits        28085    28096   +11     
- Misses      35756    35763    +7     
  Partials     1253     1253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Logo
Checkmarx One – Scan Summary & Detailsd5c6a977-6b7a-4b3a-be6b-7e4010d5e263

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 240 Attack Vector
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 406 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForSingleOrgPolicy.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 238
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 362
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 345
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 372
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 264
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 306

@voommen-livefront voommen-livefront marked this pull request as ready for review November 27, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant