[PM-8220] New Device Verification #5084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to follow logic for new device verification. Updated DeviceValidator to handle new device verification, behind a feature flag. Also move interface to new file. Updated CustomRequestValidator to take the requesting device so we only query the database once. We still query twice but only in legacy.
… for Device Verification.
|
New Issues
Fixed Issues
|
…xing code so existing tests pass
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5084 +/- ##
==========================================
- Coverage 42.92% 42.90% -0.02%
==========================================
Files 1433 1440 +7
Lines 65672 65948 +276
Branches 6022 6052 +30
==========================================
+ Hits 28191 28298 +107
- Misses 36215 36380 +165
- Partials 1266 1270 +4 ☔ View full report in Codecov by Sentry. |
rr-bw
requested review from
JaredSnider-Bitwarden
and removed request for
rr-bw
…fixing formatting
…de all device related processes for request validation.
… a single entry point for BseRequestValidator; Refactored tests for BaseRequestValidator to match changes; Updated Tests for DeviceValidator.
JaredSnider-Bitwarden
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-8220
📔 Objective
Continue QoL code improvements on
BaseRequestValidator.Users will be required to verify logins on unknown devices via email OTP.
Extras: SSO requirement will inform user before they supply two factor authentication.
📸 Screenshots
New Device Verification Required 400 response
firefox_B3x1TyDfJd.mp4
Early SSO Required failure
firefox_V0CnPmZ79t.mp4
SSO Successful
firefox_6PtVtLuiSi.mp4
SSO with Two factor successful
firefox_q2xmSbQa3b.mp4
Two Factor Request with a goof
firefox_O1gA7shwaR.mp4
Successful New Device Verification
firefox_y2EMqRVzXg.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes