fuzz: Speed up *_package_eval fuzz targets a bit #31457
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31457. ReviewsSee the guideline for information on the review process. |
dergoegge
reviewed
Dec 10, 2024
| @@ -195,8 +195,8 @@ FUZZ_TARGET(ephemeral_package_eval, .init = initialize_tx_pool) | |||
| MockTime(fuzzed_data_provider, chainstate); | |||
|
|
|||
| // All RBF-spendable outpoints outside of the unsubmitted package | |||
| std::set<COutPoint> mempool_outpoints; | |||
| std::map<COutPoint, CAmount> outpoints_value; | |||
| std::unordered_set<COutPoint, SaltedOutpointHasher> mempool_outpoints; | |||
There was a problem hiding this comment.
Using a SaltedOutpointHasher probably requires to call SeedRandomStateForTest(SeedRand::ZEROS) each iteration. Otherwise non-determinism might happen due to e.g. different order when iterating over the sets.
There was a problem hiding this comment.
Good catch. This means:
- Other tests may also need a re-seed on every iteration, if they interact with data, sorted by a salted hasher
- The speed-up may actually come from invalidating the fuzz inputs, making a change like this harder to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each target is at least 10% faster for me when running over the current set of qa-assets, which seems nice.