Prioritize request-level Authorization in headers merging #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is intended to resolve issues where the Authorization header from the request configuration was being overridden by the instance-level configuration. This adjustment ensures that request-level configurations take precedence, improving flexibility in how authorization is handled. I’ve added unit tests to ensure that the new behavior works as intended, covering various scenarios for merging headers. Please let me know if you have any questions or if there are additional scenarios you think should be covered in the tests. |
|
Addresses #6587 |
|
@BrijeshPatra You might have forgotten to push your commit with the unit test. No such file appears in the PR from what I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the mergeConfig function's headers merging logic to ensure that request-level Authorization headers take precedence over instance-level Authorization headers. This change is crucial in scenarios where multiple configurations may set Authorization, ensuring that the most specific (request-level) value is utilized.
Changes Made:
-Updated the headers merging logic to prioritize the Authorization header from config2 over config1.
Ensured that the merging of headers retains other properties as before.
Testing:
Added unit tests to cover the new merging behavior for the Authorization header.
All tests have been run and passed successfully.