transport/http: fix metrics race condition #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @lucix-aws @Madrigal |
|
gentle ping |
|
This looks fine - please create a changelog entry - see https://github.com/aws/aws-sdk-go-v2/blob/main/CONTRIBUTING.md#changelog-documents (it's the SDK repo, but the process is the same). |
|
closes #548 |
This was
linked to
issues
Jan 8, 2025
|
I added instructions / the make recipe to this repo as well: https://github.com/aws/smithy-go/blob/main/CONTRIBUTING.md#changelog-documents |
This PR fixes a race condition reported by aws#548, by introducing a simple wrapper for time.Time. While by default aws-sdk-go-v2 uses NopMeterProvider, the transport/http internals are still instrumenting the http requests (the withMetrics func). Maybe there is a room for improvement, to not call httptrace.WithClientTrace when the meter is nop, however this is out of scope for this PR.
|
@lucix-aws done |
rjeczalik
force-pushed
the
time-race-fix
branch
from
41bdd6e to
5fee405
Compare
lucix-aws
reviewed
Jan 21, 2025
lucix-aws
reviewed
Jan 21, 2025
lucix-aws
reviewed
Jan 21, 2025
lucix-aws
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition reported by #548,
by introducing a simple wrapper for time.Time.
While by default aws-sdk-go-v2 uses NopMeterProvider, the transport/http internals are still instrumenting the http requests (the withMetrics func).
Maybe there is a room for improvement, to not call httptrace.WithClientTrace when the meter is nop,
however this is out of scope for this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.