feat(events-targets): allow all ECS TaskOverrides #32344
Conversation
github-actions
bot
added
effort/small
github-actions
bot
added
the
admired-contributor
| */ | ||
| export interface EphemeralStorageOverride { | ||
| /** | ||
| * The total amount, in GiB, of ephemeral storage to set for the task. |
There was a problem hiding this comment.
I copied these docstrings from the Task Override docs: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_TaskOverride.html
| @@ -50,6 +50,54 @@ export interface EcsTaskProps extends TargetBaseProps { | |||
| */ | |||
| readonly containerOverrides?: ContainerOverride[]; | |||
|
|
|||
| /** | |||
| * The CPU override for the task. | |||
There was a problem hiding this comment.
Again, copied from the upstream docs: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_TaskOverride.html
| const taskCount = this.taskCount; | ||
| const taskDefinitionArn = this.taskDefinition.taskDefinitionArn; | ||
| const propagateTags = this.propagateTags; | ||
| const tagList = this.tags; | ||
| const enableExecuteCommand = this.enableExecuteCommand; | ||
| const input = this.createInput(); |
There was a problem hiding this comment.
Since this logic is more complex now, I refactored it to a dedicated private method.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
blimmer
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32344 +/- ##
==========================================
- Coverage 78.46% 78.45% -0.02%
==========================================
Files 106 106
Lines 7208 7208
Branches 1323 1323
==========================================
- Hits 5656 5655 -1
- Misses 1364 1365 +1
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
|
Hmm, I'm not sure why coverage would be decreasing on this PR. Any suggestions on how to improve it? |
Issue #32217
Closes #32217.
Reason for this change
ECS targets can override any item in the
TaskOverridestructure via theinputparameter, according to the docs.However, today, only the
containerOverridesoption is exposed:aws-cdk/packages/aws-cdk-lib/aws-events-targets/lib/ecs-task.ts
Lines 225 to 227 in 1b7265b
Description of changes
This PR adds all
TaskOverrideproperties to theinputparameter.Description of how you validated changes
I add unit tests. I also updated the existing integration tests to include additional overrides. I validated them in my AWS account.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license