Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rds): support 8.4.3 engine version for Amazon RDS for MySQL #32257

Merged
merged 4 commits into from
Nov 26, 2024
Merged

chore(rds): support 8.4.3 engine version for Amazon RDS for MySQL #32257

merged 4 commits into from
Nov 26, 2024

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 23, 2024

Add a new minor version.

Ref

% aws rds describe-db-engine-versions --engine mysql --query "DBEngineVersions[].EngineVersion" --output table --region us-east-1
--------------------------
|DescribeDBEngineVersions|
+------------------------+
|  5.7.44                |
|  5.7.44-rds.20240408   |
|  5.7.44-rds.20240529   |
|  5.7.44-rds.20240808   |
|  8.0.32                |
|  8.0.33                |
|  8.0.34                |
|  8.0.35                |
|  8.0.36                |
|  8.0.37                |
|  8.0.39                |
|  8.0.40                |
|  8.4.3                 |
+------------------------+

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Nov 23, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (9a4a245) to head (950def6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32257   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         105      105           
  Lines        7168     7168           
  Branches     1314     1314           
=======================================
  Hits         5553     5553           
  Misses       1433     1433           
  Partials      182      182
Flag Coverage Δ
suite.unit 77.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.46% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 23, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 25, 2024

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • queue-position = -1 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mazyu36
Copy link
Contributor Author

mazyu36 commented Nov 25, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

refresh

✅ Pull request refreshed

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 950def6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 55473c8 into aws:main Nov 26, 2024
17 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
@mazyu36 mazyu36 deleted the support-rds-mysql-8-4-3 branch November 26, 2024 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badmintoncryer badmintoncryer badmintoncryer approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazyu36 @aws-cdk-automation @GavinZZ @badmintoncryer