Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fields x overflow #3535

Closed
wants to merge 2 commits into from
Closed

fix: fields x overflow #3535

wants to merge 2 commits into from

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3530

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Before

before.mp4

After

after.mp4

@Paul-Bob Paul-Bob self-assigned this Dec 16, 2024
@github-actions github-actions bot added the Fix label Dec 16, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 16, 2024 •
edited
Loading

Code Climate has analyzed commit e71373e and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev
Copy link
Collaborator

let's wait a bit... 😅
I don't like it that much. I don't have other solutions either :P just saying.

@Paul-Bob Paul-Bob marked this pull request as draft December 16, 2024 11:22
@ObiWanKeoni
Copy link
Contributor

let's wait a bit... 😅 I don't like it that much. I don't have other solutions either :P just saying.

👋 Unsolicited comment:
Do any of these look any better?

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Dec 18, 2024 •
edited
Loading

let's wait a bit... 😅 I don't like it that much. I don't have other solutions either :P just saying.

👋 Unsolicited comment: Do any of these look any better?

IMO break-words looks good, thanks for sharing!

PS: I submitted another PR to help us evaluate which solution aligns better.

@Paul-Bob
Copy link
Contributor Author

Closing in favor of #3542

@Paul-Bob Paul-Bob closed this Dec 18, 2024
@adrianthedev
Copy link
Collaborator

@ObiWanKeoni feel free to throw all the unsolicited advice towards us.
We'll gladly take it!
Thanks for your stellar PR. We haven't forgot about it, we just need a bit more time to get into that headspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: #show sidebar - long string overflow
3 participants
@Paul-Bob @adrianthedev @ObiWanKeoni