-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: display a label with the next action for the ordering button #3454
enhancement: display a label with the next action for the ordering button #3454
Conversation
Code Climate has analyzed commit dfd1181 and detected 0 issues on this pull request. View more on Code Climate. |
@adrianthedev 👋 how does it look 👀 |
This is a good start. FYI, the sorting has a dynamic setting so you can change the initial sorting direction, so we should take that into account. Thanks for working on this @enderahmetyurt 🙏 |
This PR has been marked as stale because there was no activity for the past 15 days. |
Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️ |
Hello @enderahmetyurt, just checking in, do you have any plans to wrap this up? |
Hello. I don't have a plan yet since I couldn't reproduce it. |
The idea is to show what happens when click on the sort button. For example, if clicking the sort button arranges the records in ascending order, the title should say "Sort ascending." If clicking on it arranges them in descending order, it should say "Sort descending." What exactly is it that you can't reproduce? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort on this contribution, @enderahmetyurt.
It seems there may have been some misunderstandings regarding the implementation scope, so I've made a commit with the intended implementation.
Description
Fixes #3163 by adding a label with the next action for the ordering button.
Checklist:
Screenshots & recording
sort_label.mp4