Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: display a label with the next action for the ordering button #3454

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

enderahmetyurt
Copy link
Contributor

@enderahmetyurt enderahmetyurt commented Nov 22, 2024

Description

Fixes #3163 by adding a label with the next action for the ordering button.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

sort_label.mp4

@github-actions github-actions bot added the Chore label Nov 22, 2024
Copy link

codeclimate bot commented Nov 22, 2024

Code Climate has analyzed commit dfd1181 and detected 0 issues on this pull request.

View more on Code Climate.

@enderahmetyurt
Copy link
Contributor Author

@adrianthedev 👋 how does it look 👀

@adrianthedev
Copy link
Collaborator

This is a good start.
I guess the initial feedback was around the fact that you can't easily see what it does.
I think it should say "Sort descending" when no sorting is applied., "Sort ascending" when it's ascending, and "reset sorting when it's sorted ascending.

FYI, the sorting has a dynamic setting so you can change the initial sorting direction, so we should take that into account.

Thanks for working on this @enderahmetyurt 🙏

Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@github-actions github-actions bot closed this Jan 3, 2025
@Paul-Bob Paul-Bob reopened this Jan 3, 2025
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Jan 3, 2025

Hello @enderahmetyurt, just checking in, do you have any plans to wrap this up?

@enderahmetyurt
Copy link
Contributor Author

Hello @enderahmetyurt, just checking in, do you have any plans to wrap this up?

Hello. I don't have a plan yet since I couldn't reproduce it.

@Paul-Bob
Copy link
Contributor

Paul-Bob commented Jan 3, 2025

Hello @enderahmetyurt, just checking in, do you have any plans to wrap this up?

Hello. I don't have a plan yet since I couldn't reproduce it.

The idea is to show what happens when click on the sort button. For example, if clicking the sort button arranges the records in ascending order, the title should say "Sort ascending." If clicking on it arranges them in descending order, it should say "Sort descending."

What exactly is it that you can't reproduce?

@Paul-Bob Paul-Bob added Enhancement Not necessarily a feature, but something has improved and removed Chore labels Jan 8, 2025
@Paul-Bob Paul-Bob changed the title Show title of sorted column name enhancement: display a label with the next action for the ordering button Jan 8, 2025
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort on this contribution, @enderahmetyurt.

It seems there may have been some misunderstandings regarding the implementation scope, so I've made a commit with the intended implementation.

@Paul-Bob Paul-Bob merged commit fe108af into avo-hq:main Jan 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Not necessarily a feature, but something has improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltip to sorted columns
3 participants