Properly compare and set latest version

alexfanqi · Apr 16, 2019 · 77885a1 · 77885a1
1 parent bb9310d
commit 77885a1
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/contrib/mac/frameworkapp/JuliaLauncher/AppDelegate.m b/contrib/mac/frameworkapp/JuliaLauncher/AppDelegate.m
@@ -195,12 +195,19 @@ - (void)addJuliaVariant:(JuliaVariant *)jv {
     NSArray<NSNumber *> *vc = jv.versionComponents;
     if (vc != nil) {
       // Compare version tuple.
-      if (vc[0] > latestV[0] || (vc[0] == latestV[0] && vc[1] > latestV[1]) ||
-          (vc[0] == latestV[0] && vc[1] == latestV[1] && vc[2] > latestV[2])) {
+      if ([vc[0] isGreaterThan:latestV[0]] ||
+          ([vc[0] isEqualToNumber:latestV[0]] &&
+           [vc[1] isGreaterThan:latestV[1]]) ||
+          ([vc[0] isEqualToNumber:latestV[0]] &&
+           [vc[1] isEqualToNumber:latestV[1]] &&
+           [vc[2] isGreaterThan:latestV[2]])) {
         latestJv = jv;
         latestV = vc;
       }
     }
+    if (latestJv != self.latestKnownTaggedJulia) {
+      self.latestKnownTaggedJulia = latestJv;
+    }
   }
 }