Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden Streams SelectAsync specs #7435

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Harden Streams SelectAsync specs #7435

wants to merge 2 commits into from

Conversation

Arkatufus
Copy link
Contributor

Changes

Harden Streams SelectAsync specs:

  • make sure that we're testing the right thing
  • add missing tests

@Arkatufus
Copy link
Contributor Author

A few tests failed, we will need to look into it:

  • SelectAsync should signal completion without requiring further demand. Failed if tasks did not complete immediately.
  • Decider should be called only once when a task failed. Failed, decider was being called twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
akka-streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb