Docs: Refer to menu order with first-last #8569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8569 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
Dec 8, 2024
There was a problem hiding this comment.
@vfonic thank you. This is a good improvement. For the first paragraph it's sufficient to just state the menu item priority default since the sentence before is clear on how it's sorted.
Co-authored-by: Javier Julio <[email protected]>
Co-authored-by: Javier Julio <[email protected]>
Co-authored-by: Javier Julio <[email protected]>
Co-authored-by: Javier Julio <[email protected]>
|
@javierjulio I've used GitHub UI to accept all of your suggestions. Please re-review and feel free to squash all of these extra commits before merging. |
javierjulio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the docs,
menu priority: 1mentions that that menu item is "left most". But the new AA menu is in the sidebar, not top bar, which is top to bottom. To fix this, and not make it layout-dependent, I replaced "left" with "first" and made some other minot tweaks.