Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLT-1309] Update docker images requirements documentation #649

Merged
merged 12 commits into from
Jan 14, 2025
Merged

[PLT-1309] Update docker images requirements documentation #649

merged 12 commits into from
Jan 14, 2025

Conversation

unai-ttxu
Copy link
Member

Description

Please add the PR description here.

Related Pull Requests

  • PR number: brief description (e.g. "documentation")
  • PR number: brief description (e.g. "tests enhancements")

Pull Request Checklist:

  • [PR title] Include a title referencing a ticket in Jira (e.g. "[CLOUDS-99] Implement a new funcionality").
  • [PR desc] Add a summary of the changes made in simple terms.
  • [PR desc] List any pull-request related to this change (docs, tests, feature, etc.).
  • [PR labels] Add the corresponding labels (release, skips, cherry-pick, AT-eks-smoke, etc).
  • [Docs] Are changes to the documentation required? (if so, please add references to those PRs).
  • [QA] Are new unit tests required according with the changes? (if so, please add references to those PRs).

@unai-ttxu unai-ttxu added wip Work In Progress 0.5.8 labels Dec 27, 2024
@unai-ttxu unai-ttxu requested a review from stg-0 as a code owner December 27, 2024 16:57
@unai-ttxu unai-ttxu added documentation Improvements or additions to documentation ok-to-review and removed wip Work In Progress labels Jan 8, 2025
@unai-ttxu unai-ttxu requested a review from a team January 8, 2025 10:53
tperez-stratio
tperez-stratio suggested changes Jan 9, 2025
View reviewed changes
Copy link

@tperez-stratio tperez-stratio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unai-ttxu te paso un pequeño cambio. Fíjate que Jenkins ha sacado un enlace roto porque cambiaste el nombre de un fichero pero no el enlace. Además, habría que modificar los enlaces correspondientes en el fichero nav.adoc tanto en EN como en ES.

Pide una nueva revisión cuando esté todo listo. ¡Gracias!

stratio-docs/es/modules/operations-manual/pages/offline-installation/common-images.adoc Outdated Show resolved Hide resolved
@unai-ttxu
Copy link
Member Author

@unai-ttxu te paso un pequeño cambio. Fíjate que Jenkins ha sacado un enlace roto porque cambiaste el nombre de un fichero pero no el enlace. Además, habría que modificar los enlaces correspondientes en el fichero nav.adoc tanto en EN como en ES.

Pide una nueva revisión cuando esté todo listo. ¡Gracias!

Muchas gracias por la revisión @tperez-stratio 😄

He añadido la sugerencia y arreglado los enlaces rotos en a32fa9d

tperez-stratio
tperez-stratio approved these changes Jan 13, 2025
View reviewed changes
Copy link

@tperez-stratio tperez-stratio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unai-ttxu unai-ttxu merged commit 364dcd9 into Stratio:branch-0.17.0-0.5 Jan 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tperez-stratio tperez-stratio tperez-stratio approved these changes

@stg-0 stg-0 Awaiting requested review from stg-0

@iamjanr iamjanr Awaiting requested review from iamjanr iamjanr is a code owner

@lreciomelero lreciomelero Awaiting requested review from lreciomelero lreciomelero is a code owner

Assignees
No one assigned
Labels
0.5.8 documentation Improvements or additions to documentation ok-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unai-ttxu @tperez-stratio