Skip to content

[Enhancement] Reduce memory copy #53476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2024
Merged

[Enhancement] Reduce memory copy #53476

merged 2 commits into from
Dec 12, 2024

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Dec 3, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@Seaven Seaven requested a review from a team as a code owner December 3, 2024 08:14
@mergify mergify bot assigned Seaven Dec 3, 2024
@Seaven Seaven force-pushed the fix branch 2 times, most recently from 359e551 to 2b597d8 Compare December 6, 2024 06:48
@Seaven
Copy link
Contributor Author

Seaven commented Dec 12, 2024

@mergify rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

rebase

✅ Branch has been successfully rebased

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 25 / 26 (96.15%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ReplaceColumnRefRewriter.java 4 5 80.00% [52]
🔵 com/starrocks/sql/optimizer/rule/tree/PreAggregateTurnOnRule.java 21 21 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit d73d1e1 into StarRocks:main Dec 12, 2024
48 checks passed
@Seaven
Copy link
Contributor Author

Seaven commented Dec 19, 2024

@mergify backport branch-3.4 branch-3.3 branch-3.2 branch-3.1 branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024 •
edited
Loading

backport branch-3.4 branch-3.3 branch-3.2 branch-3.1 branch-3.0

🛑 Command backport branch-3.4 branch-3.3 branch-3.2 branch-3.1 branch-3.0 cancelled because of a new backport command with different arguments

@Seaven
Copy link
Contributor Author

Seaven commented Dec 20, 2024

@mergify backport branch-3.4 branch-3.3 branch-3.2 branch-3.1 branch-3.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024 •
edited
Loading

backport branch-3.4 branch-3.3 branch-3.2 branch-3.1 branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 20, 2024
@Seaven @mergify
[Enhancement] Reduce memory copy (#53476)
52cea0c 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
@Seaven @mergify
[Enhancement] Reduce memory copy (#53476)
9cc95de 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ReplaceColumnRefRewriter.java
@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
@Seaven @mergify
[Enhancement] Reduce memory copy (#53476)
08e75a9 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ReplaceColumnRefRewriter.java
@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
@Seaven @mergify
[Enhancement] Reduce memory copy (#53476)
919f645 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ReplaceColumnRefRewriter.java
@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
@Seaven @mergify
[Enhancement] Reduce memory copy (#53476)
8030615 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ReplaceColumnRefRewriter.java
@mergify mergify bot mentioned this pull request Dec 20, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024
@mergify @Seaven
[Enhancement] Reduce memory copy (backport #53476) (#54159)
f615212 
Co-authored-by: Seaven <[email protected]>
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
b81f836 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
1ca46ea 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
7781775 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
0c0c28c 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
9913fce 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024
@mergify @Seaven
[Enhancement] Reduce memory copy (backport #53476) (#54163)
0693c29 
Co-authored-by: Seaven <[email protected]>
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
e248a93 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
a413a1c 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
b3bffe6 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
6e2d61f 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024
@mergify @Seaven
[Enhancement] Reduce memory copy (backport #53476) (#54162)
cdded5b 
Co-authored-by: Seaven <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024
@mergify @Seaven
[Enhancement] Reduce memory copy (backport #53476) (#54161)
85c10a8 
Co-authored-by: Seaven <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 20, 2024
@mergify @Seaven
[Enhancement] Reduce memory copy (backport #53476) (#54160)
6e305f6 
Co-authored-by: Seaven <[email protected]>
Seaven added a commit that referenced this pull request Dec 20, 2024
@Seaven
[Enhancement] Reduce memory copy (#53476)
506297a 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit d73d1e1)
wanpengfei-git pushed a commit that referenced this pull request Dec 23, 2024
@Seaven
[BugFix] Fix replaceColumnRef bug (backport #53476) (#54197)
4d5e384
zhangyifan27 pushed a commit to zhangyifan27/starrocks that referenced this pull request Feb 10, 2025
@mergify @Seaven
[Enhancement] Reduce memory copy (backport StarRocks#53476) (StarRock…
4e3eb5a 
…s#54160)

Co-authored-by: Seaven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@stephen-shelby stephen-shelby stephen-shelby approved these changes

Assignees

@Seaven Seaven

Labels
3.0-merged 3.0 3.1-merged 3.1 3.2-merged 3.2 3.3-merged 3.3 3.4-merged 3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seaven @kangkaisen @stephen-shelby