Skip to content

[BugFix] Repair GC logic for shared-data persistent index while multi-disk is used for storage #53469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

[BugFix] Repair GC logic for shared-data persistent index while multi-disk is used for storage #53469

merged 1 commit into from
Dec 4, 2024

Conversation

wxl24life
Copy link
Contributor

@wxl24life wxl24life commented Dec 3, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #53471

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@wxl24life wxl24life requested a review from a team as a code owner December 3, 2024 06:31
@sevev
Copy link
Contributor

sevev commented Dec 3, 2024

Can you describe the specific bug and explain the cause of it?

@wxl24life
Copy link
Contributor Author

Can you describe the specific bug and explain the cause of it?

done

@wxl24life wxl24life force-pushed the xiaolong/shared-data-persistent-index-gc-repair branch from 0f4f48b to 7bd0467 Compare December 3, 2024 06:44
kevincai
kevincai reviewed Dec 3, 2024
View reviewed changes
smartlxh
smartlxh reviewed Dec 3, 2024
View reviewed changes
@wxl24life wxl24life force-pushed the xiaolong/shared-data-persistent-index-gc-repair branch from fa01095 to f7ebdef Compare December 3, 2024 14:01
smartlxh
smartlxh reviewed Dec 3, 2024
View reviewed changes
kevincai
kevincai reviewed Dec 4, 2024
View reviewed changes
@wxl24life wxl24life force-pushed the xiaolong/shared-data-persistent-index-gc-repair branch from fdb5aab to 3e541a3 Compare December 4, 2024 05:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

[BE Incremental Coverage Report]

✅ pass : 19 / 21 (90.48%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/local_pk_index_manager.cpp 19 21 90.48% [114, 117]

@caneGuy caneGuy enabled auto-merge (squash) December 4, 2024 08:08
@caneGuy caneGuy merged commit db4753f into StarRocks:main Dec 4, 2024
50 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Dec 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
@wxl24life @mergify
[BugFix] Repair GC logic for shared-data persistent index while multi…
e650899 
…-disk is used for storage (#53469)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit db4753f)
mergify bot pushed a commit that referenced this pull request Dec 4, 2024
@wxl24life @mergify
[BugFix] Repair GC logic for shared-data persistent index while multi…
778c882 
…-disk is used for storage (#53469)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit db4753f)
@mergify mergify bot mentioned this pull request Dec 4, 2024
Open
42 tasks
mergify bot pushed a commit that referenced this pull request Dec 4, 2024
@wxl24life @mergify
[BugFix] Repair GC logic for shared-data persistent index while multi…
c00f92c 
…-disk is used for storage (#53469)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit db4753f)
This was referenced Dec 4, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 4, 2024
@wxl24life @mergify
[BugFix] Repair GC logic for shared-data persistent index while multi…
4ca925a 
…-disk is used for storage (#53469)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit db4753f)
@mergify mergify bot mentioned this pull request Dec 4, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 4, 2024
@mergify @wxl24life
[BugFix] Repair GC logic for shared-data persistent index while multi…
1cb6eaf 
…-disk is used for storage (backport #53469) (#53540)

Co-authored-by: Drake Wang <[email protected]>
@wxl24life wxl24life deleted the xiaolong/shared-data-persistent-index-gc-repair branch December 4, 2024 10:51
wanpengfei-git pushed a commit that referenced this pull request Dec 5, 2024
@mergify @wxl24life @sevev
[BugFix] Repair GC logic for shared-data persistent index while multi…
b2cab3a 
…-disk is used for storage (backport #53469) (#53542)

Signed-off-by: zhangqiang <[email protected]>
Co-authored-by: Drake Wang <[email protected]>
Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Dec 6, 2024
@mergify @wxl24life
[BugFix] Repair GC logic for shared-data persistent index while multi…
7b235d9 
…-disk is used for storage (backport #53469) (#53541)

Co-authored-by: Drake Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartlxh smartlxh smartlxh left review comments

@kevincai kevincai kevincai approved these changes

@sevev sevev sevev approved these changes

@caneGuy caneGuy caneGuy approved these changes

Assignees

@wxl24life wxl24life

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local persistent index failed to remove old dir while new disk added
5 participants
@wxl24life @sevev @kevincai @smartlxh @caneGuy