Skip to content

[BugFix] Revert [Enhancement] make connector scan operator profile less skew#53465

Merged
kangkaisen merged 1 commit intoStarRocks:mainfrom
before-Sunrise:fix_profile
Dec 5, 2024
Merged

[BugFix] Revert [Enhancement] make connector scan operator profile less skew#53465
kangkaisen merged 1 commit intoStarRocks:mainfrom
before-Sunrise:fix_profile

Conversation

@before-Sunrise
Copy link
Contributor

@before-Sunrise before-Sunrise commented Dec 3, 2024

revert #52676, which cause profile scan time is wrong

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@before-Sunrise before-Sunrise requested a review from a team as a code owner December 3, 2024 05:28
@satanson satanson enabled auto-merge (squash) December 3, 2024 06:41
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

[BE Incremental Coverage Report]

❌ fail : 20 / 27 (74.07%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/connector/lake_connector.cpp 0 3 00.00% [364, 408, 659]
🔵 be/src/exec/tablet_scanner.cpp 0 4 00.00% [377, 401, 408, 415]
🔵 be/src/exec/pipeline/scan/connector_scan_operator.cpp 2 2 100.00% []
🔵 be/src/exec/stream/scan/stream_scan_operator.cpp 2 2 100.00% []
🔵 be/src/exec/pipeline/scan/olap_chunk_source.cpp 3 3 100.00% []
🔵 be/src/exec/pipeline/scan/olap_scan_operator.cpp 2 2 100.00% []
🔵 be/src/exec/pipeline/scan/scan_operator.cpp 9 9 100.00% []
🔵 be/src/exec/pipeline/scan/schema_scan_operator.cpp 2 2 100.00% []

@kangkaisen kangkaisen disabled auto-merge December 5, 2024 02:51
@kangkaisen kangkaisen merged commit 2719242 into StarRocks:main Dec 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

@Mergifyio backport branch-3.4

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

@Mergifyio backport branch-3.3

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

Details

@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Dec 5, 2024
@before-Sunrise @mergify
[BugFix] Revert [Enhancement] make connector scan operator profile le…
fdaa372 
…ss skew (#53465)

(cherry picked from commit 2719242)
@mergify mergify bot mentioned this pull request Dec 5, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Dec 5, 2024
@before-Sunrise @mergify
[BugFix] Revert [Enhancement] make connector scan operator profile le…
34689b7 
…ss skew (#53465)

(cherry picked from commit 2719242)

# Conflicts:
#	be/src/connector/lake_connector.cpp
#	be/src/exec/pipeline/scan/olap_chunk_source.cpp
@mergify mergify bot mentioned this pull request Dec 5, 2024
Closed
42 tasks
@before-Sunrise before-Sunrise mentioned this pull request Dec 5, 2024
Merged
24 tasks
dirtysalt pushed a commit that referenced this pull request Dec 5, 2024
@before-Sunrise
[BugFix] Revert [Enhancement] make connector scan operator profile le…
9d45df8 
…ss skew (backport #53465) (#53592)
wanpengfei-git pushed a commit that referenced this pull request Dec 5, 2024
@mergify @before-Sunrise
[BugFix] Revert [Enhancement] make connector scan operator profile le…
c36752d 
…ss skew (backport #53465) (#53581)

Co-authored-by: before-Sunrise <[email protected]>
meegoo pushed a commit to meegoo/starrocks that referenced this pull request Dec 10, 2024
@before-Sunrise @meegoo
[BugFix] Revert [Enhancement] make connector scan operator profile le…
c07f7b6 
…ss skew (backport StarRocks#53465) (StarRocks#53592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@satanson satanson satanson approved these changes

@ZiheLiu ZiheLiu ZiheLiu approved these changes

Assignees

@before-Sunrise before-Sunrise

Labels

3.3-merged 3.4-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@before-Sunrise @dirtysalt @satanson @ZiheLiu @kangkaisen