[Refactor] Set error but not exit BE when delvec inconsistent#53460
Merged
wyb merged 2 commits intoStarRocks:mainfrom Dec 12, 2024
Merged
[Refactor] Set error but not exit BE when delvec inconsistent#53460wyb merged 2 commits intoStarRocks:mainfrom
wyb merged 2 commits intoStarRocks:mainfrom
Conversation
Contributor
Author
|
@mergify rebase |
Signed-off-by: sevev <[email protected]>
Contributor
✅ Branch has been successfully rebased |
Signed-off-by: sevev <[email protected]>
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 5 / 5 (100.00%) file detail
|
kevincai
approved these changes
Dec 6, 2024
wyb
approved these changes
Dec 12, 2024
Contributor
Author
|
@mergify backport branch-3.4 |
Contributor
✅ Backports have been createdDetails
|
Contributor
Author
|
@mergify backport branch-3.3 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 27a994c)
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Signed-off-by: sevev <[email protected]> (cherry picked from commit 27a994c)
This was referenced Dec 17, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 17, 2024
#53460) (#54004) Co-authored-by: zhangqiang <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 17, 2024
#53460) (#54003) Co-authored-by: zhangqiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When BE meets delvec inconsistent error, BE will crash right now and BE can not restart. However, we can set tablet error but not crash BE and remove the replica to handle this problem.
What I'm doing:
Set error but not crash BE.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: