allow custom error when form does not use a model

This PR change the has_errors? method to allow custom errors on forms without a model
Sgtpluck · May 28, 2018 · 09c928f · 09c928f
1 parent 1e35f20
commit 09c928f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/simple_form/components/errors.rb b/lib/simple_form/components/errors.rb
@@ -11,7 +11,7 @@ def full_error(wrapper_options = nil)
       end
 
       def has_errors?
-        object && object.respond_to?(:errors) && errors.present?
+        object_with_errors? || object.nil? && has_custom_error?
       end
 
       def has_value?
@@ -34,6 +34,10 @@ def full_error_text
         has_custom_error? ? options[:error] : full_errors.send(error_method)
       end
 
+      def object_with_errors?
+        object && object.respond_to?(:errors) && errors.present?
+      end
+
       def error_method
         options[:error_method] || SimpleForm.error_method
       end

diff --git a/test/form_builder/error_test.rb b/test/form_builder/error_test.rb
@@ -224,6 +224,12 @@ def with_full_error_for(object, *args)
     assert_no_select 'span.error'
   end
 
+  test 'input with custom error works when form does not use a model' do
+    with_form_for :user, :active, error: "Super User Active! cannot be blank"
+
+    assert_select 'span.error'
+  end
+
   test 'input with custom error works when using full_error component' do
     swap_wrapper :default, custom_wrapper_with_full_error do
       error_text = "Super User Name! cannot be blank"