Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set LangVersion compiler option to 13.0 in Test.Common.props #24621

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Set LangVersion compiler option to 13.0 in Test.Common.props #24621

merged 1 commit into from
Feb 8, 2025

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 26, 2024 •
edited by iSazonov
Loading

Close #24622

  • test/Test.Common.props

iSazonov
iSazonov reviewed Nov 27, 2024
View reviewed changes
test/tools/WebListener/Controllers/GetController.cs
@@ -17,13 +17,13 @@ public JsonResult Index()
Hashtable args = new Hashtable();
foreach (var key in Request.Query.Keys)
{
args.Add(key, string.Join(Constants.HeaderSeparator, Request.Query[key]));
args.Add(key, string.Join(Constants.HeaderSeparator, (string)Request.Query[key]));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fixed in Runtime repository. Is there an issue for the pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please report to Runtime repo the issue?

I see there are:
dotnet/runtime#101261
dotnet/runtime#101499
dotnet/runtime#101457

@xtqqczze I suggest to revert to 11.0 lang for the test project so that we can merge and don't wait comments from dotnet team.

Originally posted by @iSazonov in #24617 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/runtime#101499 is labelled needs-breaking-change-doc-created

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started discussion: dotnet/runtime#110216

Copy link
Collaborator

@iSazonov iSazonov Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explicitly report (with repro steps) about the issue with cast needed? I guess it is not doc issue, it should be fixed in Runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the issue is with Microsoft.Extensions.Primitives.StringValues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is a breaking change, resolution is by updating code, e.g. dotnet/aspnetcore@7e353a3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened issue: dotnet/docs#44102

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

test/tools/WebListener/Controllers/GetController.cs(20,38): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]
test/tools/WebListener/Controllers/GetController.cs(26,41): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is a breaking change, resolution is by updating code, e.g. dotnet/aspnetcore@7e353a3

@iSazonov This is a confirmed breaking change in .NET 9, see dotnet/docs#44102 (comment).

@xtqqczze xtqqczze marked this pull request as draft November 27, 2024 09:18
@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 1, 2024
@xtqqczze xtqqczze marked this pull request as ready for review December 3, 2024 23:14
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Dec 17, 2024
@xtqqczze xtqqczze requested a review from iSazonov December 28, 2024 23:39
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 7, 2025

@iSazonov can you please review?

@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 8, 2025
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 8, 2025

/azp run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Feb 8, 2025
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@iSazonov iSazonov self-assigned this Feb 8, 2025
@iSazonov iSazonov changed the title Set LangVersion compiler option to 13.0 Set LangVersion compiler option to 13.0 in Test.Common.props Feb 8, 2025
@iSazonov iSazonov enabled auto-merge (squash) February 8, 2025 06:59
@iSazonov iSazonov merged commit f22ad2e into PowerShell:master Feb 8, 2025
39 of 41 checks passed
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 8, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@xtqqczze xtqqczze deleted the LangVersion2 branch February 8, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@iSazonov iSazonov

Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set LangVersion compiler option to 13.0
2 participants
@xtqqczze @iSazonov