Return an ExcelException object rather than a string to represent MS Excel formula errors#1605
Draft
Return an ExcelException object rather than a string to represent MS Excel formula errors#1605
Conversation
added 26 commits
August 4, 2020 09:47
…Excel formula errors, so that formulae that return string values that do begin with a '#' can be distinguished from actual formula errors
…ing only its problems with the unit tests... pity it doesn't recognise the validity of previous assertions in a test
…hod only `/*` is allowed?!?
added 3 commits
August 7, 2020 17:20
…at I'm not handling a thrown exception, and phpcs complaining that I have a @throws annotation in the docblock
added 9 commits
August 7, 2020 18:44
…at I'm not handling a thrown exception, and phpcs complaining that I have a @throws annotation in the docblock
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an ExcelException object rather than a string to represent MS Excel formula errors, so that formulae that return string values that do begin with a '#' can be distinguished from actual formula errors
This is:
Checklist:
Why this change is needed?