Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English Translation #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

English Translation #1

wants to merge 1 commit into from

Conversation

tijevlam
Copy link

  • Because iI like this setup to easily practice basic regex I wanted to make it available for my non-spanish speaking teammates. And thus, I included an English translation for all game related parts. On a level basis this would be easily extended to other languages too. For the UI-texts, the setup isnt ideal for multi-languages. It might need a seperate i18n setup.
  • The language selector is available in the footer. This could be a selector with flags in the future.
  • The chosen language is stored in localStorage to return in its same state when you return later.

- Because iI like this setup to easily practice basic regex I wanted to make it available for my non-spanish speaking teammates. And thus, I included an English translation for all game related parts. On a level basis this would be easily extended to other languages too. For the UI-texts, the setup isnt ideal for multi-languages. It might need a seperate i18n setup.
- The language selector is available in the footer. This could be a selector with flags in the future.
- The chosen language is stored in localStorage to return in its same state when you return later.
@tijevlam
Copy link
Author

@ManzDev its been quite some time... could you take a look at this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant