Add PyKEEN to ecosystem-ci #50
Conversation
configs/pykeen/pykeen.yaml
Outdated
| runtimes: | ||
| - {os: "ubuntu-20.04", python-version: "3.10"} | ||
| - {os: "macOS-10.15", python-version: "3.9"} | ||
| - {os: "windows-2019", python-version: "3.8"} |
There was a problem hiding this comment.
In PyKEEN we are testing with Python 3.8 and 3.10, which are the minimum and maximum Python version we officially support. We test for both, Ubuntu and Windows, but do not have specific tests for macOS.
If you have any suggestions here, feel free to share them. The main reason we are interested in integrating with PyTorchLightning/ecosystem-ci is the possibility to run tests with GPUs, which we at PyKEEN do not have available for continous testing.
There was a problem hiding this comment.
that is fine we can test only Linux and Win or just Ubuntu 🦦
|
|
||
| contact: | ||
| slack: | ||
| - U03DAAVMLSH |
There was a problem hiding this comment.
This is my Slack account at https://pytorch-lightning.slack.com
|
the errors seem to originate from a torch.multiprocessing.spawn.ProcessRaisedException:
E
E -- Process 1 terminated with the following error:
Traceback (most recent call last):
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 69, in _wrap
fn(i, *args)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/strategies/launchers/spawn.py", line 101, in _wrapping_function
results = function(*args, **kwargs)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 809, in _fit_impl
results = self._run(model, ckpt_path=self.ckpt_path)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1234, in _run
results = self._run_stage()
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1321, in _run_stage
return self._run_train()
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1343, in _run_train
self._run_sanity_check()
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1411, in _run_sanity_check
val_loop.run()
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 154, in advance
dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 122, in advance
self._on_evaluation_batch_start(**kwargs)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 249, in _on_evaluation_batch_start
self.trainer._call_callback_hooks(hook_name, *kwargs.values())
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 1634, in _call_callback_hooks
fn(self, self.lightning_module, *args, **kwargs)
File "/home/AzDevOps_azpcontainer/.local/lib/python3.8/site-packages/pytorch_lightning/callbacks/progress/tqdm_progress.py", line 291, in on_validation_batch_start
self.val_progress_bar.reset(convert_inf(self.total_val_batches_current_dataloader))
File "/opt/conda/lib/python3.8/site-packages/tqdm/std.py", line 1408, in reset
self.last_print_t = self.start_t = self._time()
AttributeError: 'Tqdm' object has no attribute '_time'@aniketmaurya any idea how to fix / investigate this issue? |
|
Seems like TQDM version compatibility issue. Cc: @Borda |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==================================
Coverage 85% 85%
==================================
Files 2 2
Lines 230 230
==================================
Hits 196 196
Misses 34 34 |
any updates on this? |
|
@mberr I am very sorry for the delay, but I ll take look at it this week as we are rolling some more updates 🦦 |
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
@Borda no problem - great that this is now regaining momentum; I accepted your proposed changes in 597f7c2...4cd6fae and merged with the current |
|
This error message looks strange to me: The respective version is available through pypi: https://pypi.org/project/torch-max-mem/0.0.4/ This one seems to come from |
Before submitting
runtimesin config for GitHub action integration?What does this PR do? [optional]
Project: https://github.com/pykeen/pykeen
PyL integration via
Did you have fun?
Make sure you had fun coding 🙃