Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eltype of flatten of tuple with non-2 length #56802

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+18 −2
Open

Fix eltype of flatten of tuple with non-2 length #56802

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeb3473
Fix eltype of flatten of tuple with non-2 length
jakobnissen Dec 11, 2024
d084db4
Use foldable meta?
jakobnissen Dec 11, 2024
184153e
Delete dead code
jakobnissen Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Delete dead code
  • Loading branch information
@jakobnissen
jakobnissen committed Dec 11, 2024
commit 184153e00def48bb516785fae34c0c75cfa38ed6
1 change: 0 additions & 1 deletion base/iterators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,6 @@ function eltype(::Type{Flatten{I}}) where {I<:Union{Tuple,NamedTuple}}
T
end

promote_typejoin(map(eltype, fieldtypes(I))...)
eltype(::Type{Flatten{Tuple{}}}) = eltype(Tuple{})
IteratorEltype(::Type{Flatten{I}}) where {I} = _flatteneltype(I, IteratorEltype(I))
IteratorEltype(::Type{Flatten{Tuple{}}}) = IteratorEltype(Tuple{})
Expand Down
Loading