Fully outline all GlobalRefs #56746
Merged
Fully outline all GlobalRefs #56746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #56724, these numbers also get better: they are 154.2 MB => 154.8 MB (sysimg data) and 254 MB => 260M (stdlibs folder) |
Keno
force-pushed
the
kf/outlineallglobals
branch
from
d6bd32c to
0fc8cc1
Compare
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 5, 2024
There's no guarantee that all include calls will be literal GlobalRefs and in fact JuliaLang/julia#56746 will likely make them never GlobalRef.
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 5, 2024
There's no guarantee that all include calls will be literal GlobalRefs and in fact JuliaLang/julia#56746 will likely make them never GlobalRef.
Keno
force-pushed
the
kf/outlineallglobals
branch
from
0fc8cc1 to
0c18877
Compare
|
Need to merge timholy/Revise.jl#869 then rerun CI here. |
Keno
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 5, 2024
There's no guarantee that all include calls will be literal GlobalRefs and in fact JuliaLang/julia#56746 will likely make them never GlobalRef.
Keno
force-pushed
the
kf/outlineallglobals
branch
from
0c18877 to
9758917
Compare
This is an alternative to #56714 that goes in the opposite direction - just outline all GlobalRefs during lowering. It is a lot simpler that #56714 at the cost of some size increase. Numbers: sys.so .ldata size: This PR: 159.8 MB Master: 158.9 MB I don't have numbers of #56714, because it's not fully complete. Additionally, it's possible that restricting GlobalRefs from arguments position would let us use a more efficient encoding in the future.
Keno
force-pushed
the
kf/outlineallglobals
branch
from
9758917 to
6955f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #56714 that goes in the opposite direction - just outline all GlobalRefs during lowering. It is a lot simpler that #56714 at the cost of some size increase. Numbers:
sys.so .ldata size:
This PR: 159.8 MB
Master: 158.9 MB
I don't have numbers of #56714, because it's not fully complete. Additionally, it's possible that restricting GlobalRefs from arguments position would let us use a more efficient encoding in the future.