Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for non-zero denominator in iszero for Rational #54874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check for non-zero denominator in iszero for Rational #54874

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a8ff56
Don't count 0//0 as zero
jishnub Jun 21, 2024
eb21847
Check that denominator is one
jishnub Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check that denominator is one
  • Loading branch information
@jishnub
jishnub committed Jun 24, 2024
commit eb21847f7c3cc795502d22eee3185c828066090f
2 changes: 1 addition & 1 deletion base/rational.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ function ^(z::Complex{<:Rational}, n::Integer)
n >= 0 ? power_by_squaring(z,n) : power_by_squaring(inv(z),-n)
end

iszero(x::Rational) = iszero(numerator(x)) && !iszero(denominator(x))
iszero(x::Rational) = iszero(numerator(x)) && isone(denominator(x))
isone(x::Rational) = isone(numerator(x)) & isone(denominator(x))

function lerpi(j::Integer, d::Integer, a::Rational, b::Rational)
Expand Down