Dart: WEB-41595 call hierarchy: jump to caller position#870
Closed
hpoul wants to merge 1 commit intoJetBrains:masterfrom
Closed
Dart: WEB-41595 call hierarchy: jump to caller position#870hpoul wants to merge 1 commit intoJetBrains:masterfrom
hpoul wants to merge 1 commit intoJetBrains:masterfrom
Conversation
hpoul
changed the title
Contributor
|
Thank you for the PR and sorry for the delay with the review. First comment: would you agree that there's no need to change logic in 'callee' mode? I mean that clicking on
|
Contributor
|
The Dart plugin will be managed by Google from now on. The new repository is https://github.com/flutter/dart-intellij-third-party. So I'm closing the PR here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When showing caller hierarchy, jump to the actual location of the invocation, not to the enclosed function.
If there are multiple invocations inside a function all locations will be highlighted, similar to how the java plugin works.
For some reason I have a few test failures.. but when reverting to the original master, I have the same failures.. so I don't think my changes caused them. Can someone reproduce this? thanks.
https://youtrack.jetbrains.com/issue/WEB-41595/Dart-plugin-Call-hierarchy-should-navigate-to-call-side-not-surrounding-function