IDEA-311825 Support MVNW_ variables for downloading maven wrapper#2873
Closed
nrayburn-tech wants to merge 1 commit intoJetBrains:masterfrom
Closed
IDEA-311825 Support MVNW_ variables for downloading maven wrapper#2873nrayburn-tech wants to merge 1 commit intoJetBrains:masterfrom
nrayburn-tech wants to merge 1 commit intoJetBrains:masterfrom
Conversation
nrayburn-tech
force-pushed
the
fix-IDEA-311825
branch
3 times, most recently
from
60d1ea7 to
e32da48
Compare
Contributor
Author
|
Added a test for the new behavior. @zulkar any idea when this might be reviewed or if there's anything else I need to do for it? |
Contributor
|
@nrayburn-tech thanks for commit, sorry for long time to reply. Could you please make some fixes and rebase the project, I'll merge it? |
…r downloading Maven wrapper
nrayburn-tech
force-pushed
the
fix-IDEA-311825
branch
from
e32da48 to
5de1010
Compare
Contributor
Author
|
@zulkar this PR should be updated now. Let me know if any other changes need to be made. Thanks for following up on this, it's still something I'm definitely interested in using within the IDE. |
Contributor
|
merged and commited, thank you/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the below variables when trying to download the maven wrapper.