Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Toast Notification Added #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chandsharma
Copy link

Windows Toast Notification will show after daily commit is done.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 15, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.49%.

Quality metrics Before After Change
Complexity 0.13 ⭐ 0.16 ⭐ 0.03 👎
Method Length 34.25 ⭐ 32.20 ⭐ -2.05 👍
Working memory 5.47 ⭐ 4.68 ⭐ -0.79 👍
Quality 86.62% 89.11% 2.49% 👍
Other metrics Before After Change
Lines 23 28 5
Changed files Quality Before Quality After Quality Change
main.py 86.62% ⭐ 89.11% ⭐ 2.49% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@chandsharma
Copy link
Author

This is a good project. Nice work done by creator.
Tried to add a feature to make it more awesome 👍🏼

@bestadamdagoat
Copy link

Win10Toast seems to be no longer maintained. The last commit was on January 26, 2018. I'd look into using plyer, it's still maintained and allows notifications on Windows/OSx/Linux.

@bestadamdagoat
Copy link

Win10Toast seems to be no longer maintained. The last commit was on January 26, 2018. I'd look into using plyer, it's still maintained and allows notifications on Windows/OSx/Linux.

I decided to do this myself and opened my own PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants