Gui: Fix render order of datum planes #18878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Core
kadet1090
force-pushed
the
fix-render-order-of-datum-planes
branch
4 times, most recently
from
9a42fdf to
53bb64e
Compare
kadet1090
force-pushed
the
fix-render-order-of-datum-planes
branch
from
53bb64e to
74179e0
Compare
|
@kadet1090 so just to be sure, it changes the appearance order but when clicking on overlapping areas, you select the object which was previously rendered on top and is now on the back (so selecting the not the one as you would think)? |
|
Kinda, it works really strange with and without this modification so it is not a regression |
|
Is the preselection style different enough to show what plane will be selected or is currently focused? |
|
Yes. I'll probably update the style of planes to expand on hover in later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes rendering order of datum planes. It achieves it by modifying
So3DAnnotationto include separate delayed render queue that is rendered after the scene with cleared depth buffer. Depth buffer was previously cleared for every So3DAnnotation instance independently. Basically it introduces ability to draw annotations on separate layer.This PR does NOT fix picking order - as far as I know it is not possible to do without modifying coin itself as it would require to introduce not only rendering, but also picking layers (or priorities) into SoRayPickAction.
Someone more knowledgeable in the area (@wwmayer) may know some way - if we would be able to extract all shapes intersected with ray and their priorities we could in theory implement it on our side.
The way that it is implemented is poor, and I am fully aware of it - but without modifying coin code it is hard to implement stuff like that.
@PaddleStroke FYI