Gui: Mark mouse move action handled to skip digging nodes #18860
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Core
|
@Rexbas maybe you could take a look at this |
|
I have had a quick look. I downloaded a random DXF file and with this PR the duration of As for the ray pick action, I have attempted to improve its performance in coin last week but had some technical difficulties, I will try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is suitable modification but,
SoNode::traversalis bottle neck of mouse hover operation in importing DXF, like following.As you can see the worst bottle neck is digging down
SoNodetree, but I think that digging down does nothing since the selection is already done bySoFCUnifiedSelection::handleEvent(similar to selection). If so, mark the action handled to skip digging down and performance bottle neck is moving to ray pick action like this.I opened this PR as draft because I'm not familiar with FreeCAD and Coin3D. Please tell me if the modification will break any feature.
rel: #17185
sa: coin3d/coin#542 (ray pick action performance)