BIM: Speedup and refactor WebGL exporting #18843
Conversation
je-cook
changed the title
|
@je-cook does this fix any open webgl issues: https://github.com/FreeCAD/FreeCAD/issues?q=is%3Aopen+is%3Aissue+label%3A%22File+format%3A+WebGL%22 ? |
|
Great job! I'm only a bit worried by the added numpy dependency... The webGL exporter could just stop working for some users. Could you check if it's included in our builds first? |
|
Thanks @yorikvanhavre I guessed that numpy was because it is already imported in a few modules in Its definitely in the pixi.toml and the conda build and Line 27 in e15285a |
|
Okay indeed it is, and it's used in many place in FreeCAD already (CAM, FEM,...) so I suppose it's good to go! |
Hi,
I was using the webgl exporter which works great for simple shapes but once the objects become more complicated the compression step takes a long time because of the nested for loops.
In the first commit I have taken the opportunity while I was in the file to refactor it slightly and split some functionality out into standalone functions.
With the second commit I have used numpy to avoid some of the python nested for loops used in compression. For me this makes the saving of more complex shapes nearly instantaneous.