Fem: Display popup menu when MeshGroup solid selection is ambiguous #18812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be cool to have something like this, not only for solids but also other internal geometrical entities. This can be a good start though. @marioalexis84 FYI |
|
Type hints are currently not used throughout the Fem module. |
colinRawlings
force-pushed
the
fem-select_enclosed_solid
branch
2 times, most recently
from
d9eae7a to
f1e1eef
Compare
|
@marioalexis84 I am a huge fan of type hinting, so I am in favor of keeping it as. |
colinRawlings
force-pushed
the
fem-select_enclosed_solid
branch
from
f1e1eef to
a94a28b
Compare
|
@marioalexis84 Is anything else needed from my side to advance this (first time doing a PR both for FreeCAD and with github so not really sure what the process is)? |
|
@FEA-eng @marioalexis84 good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable selection of solids which are enclosed within an outer solid.
If the selected face or edge belongs to multiple solids provide a popup to allow the user to select which solid they wish to add.
Closes #5913
demo.webm