Center text in spreadsheet vertical headers #18738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mod: Spreadsheet
|
Of course, this is not connected to this PR, but I ought to add ― the screenshots provided use different style(sheet)s and the newer is flatter and more vapid. |
|
Nice! |
|
@xtemp09 I've now added a screenshot from current head |
This uses text alignment to center the numbers so there's no cutoff: |
|
@hyarion this is awesome. Do you mind |
hyarion
force-pushed
the
center-spreadsheet-row-headers
branch
from
37014c7 to
b27eff3
Compare
hyarion
force-pushed
the
center-spreadsheet-row-headers
branch
from
b27eff3 to
0c1b468
Compare
|
@luzpaz done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be a de facto standard in spreadsheet applications to center text both in column and row headers, however in qt, default seem to be to left align row header text.
This PR changes the alignment so it matches other spreadsheet applications such as google sheets, excel, numbers, excel, open office (even lotus 1-2-3 for windows).
As mentioned in this other PR comment, centering text needs to be done in code rather than in style sheets. By doing it in code, it is also fixes it in Classic.
Before (classic 1.0):
Before (classic 1.1.0dev head+qt6-this modification):
After (classic 1.1.0dev head+qt6+this modification):
