-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro: allow to specify extra system paths for macro #18525
Conversation
367cd2a
to
673ed78
Compare
98ca010
to
3840022
Compare
@chennes promised to look at it before this Friday |
@chennes here is a reminder 😄 |
3840022
to
5e0983a
Compare
Overall I think this is a great addition -- I've long wanted the ability to have multiple macro directories (right now the Addon Manager has to copy the FCMacro files out of an Addon and install them into the user's macro directory, and this can eliminate the complexity that creates). I think in the long run we'd like this to be configurable via a user-accessible preference, but that can certainly wait for a follow-up PR. So in my opinion this is basically good to go (pending my above concern about the printing code modifying a variable that isn't being passed by reference). But I would like @wwmayer to give this a brief look to ensure I'm not missing something critical about modifying these search paths (which can have unintended consequences). |
5e0983a
to
5e13094
Compare
I am actually working on the declarative configuration way from nix. For now, I implemented the configuration the list of modules, python paths, start-up user configuration file and extra flags for QT. The macros are missing for now, so I needed for this functionality to finish this. |
5e13094
to
b37c341
Compare
This introduce new option `-E [ --macro-path]` to specify extra system paths of macros. The macro found in this paths will appear in `Macros` dialog at `System macros` tab. Change-Id: Ic21631ec0ebe8af5c7f42b4fe95400cfb67807d5
b37c341
to
ca34c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine now.
By mistake the user macro list was cleared on each fillUpList call withing FreeCAD#18525. This fixes FreeCAD#18933
By mistake the user macro list was cleared on each fillUpList call withing FreeCAD#18525. This fixes FreeCAD#18933
By mistake the user macro list was cleared on each fillUpListForDir call withing FreeCAD#18525. This fixes FreeCAD#18933
This introduce new option
-E [ --macro-path]
to specify extra system paths of macros. The macro found in this paths will appear inMacros
dialog atSystem macros
tab.Will fix #18343