Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batched reverse mode #2216

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Batched reverse mode #2216

merged 4 commits into from
Jan 7, 2025

Conversation

jumerckx
Copy link
Collaborator

@jumerckx jumerckx commented Jan 3, 2025

In trying to get a simple reverse test to work I noticed the broadcastOp insertion was in the wrong place. Now it works.
BroadcastOp does not participate in CSE yet, though.

@jumerckx
Copy link
Collaborator Author

jumerckx commented Jan 3, 2025 •
edited
Loading

Also @wsmoses, I noticed you fixed some typos in the tests of my previous pr, sorry about that, I didn't realize CI doesn't run MLIR tests.
(I also still need to verify the test in this pr locally :))

@jumerckx
Copy link
Collaborator Author

jumerckx commented Jan 6, 2025

Should be good to go, will merge after ci.

@wsmoses
Copy link
Member

wsmoses commented Jan 6, 2025 

  targets in the same directory, add PARTIAL_SOURCES_INTENDED to the target
  specification, though it is discouraged.

  Please update
  /mnt/Data/_work/Enzyme/Enzyme/Enzyme/enzyme/Enzyme/MLIR/Passes/CMakeLists.txt

I'll fix this

@wsmoses wsmoses enabled auto-merge January 7, 2025 03:51
@wsmoses wsmoses disabled auto-merge January 7, 2025 03:51
@wsmoses wsmoses merged commit 96b8efc into EnzymeAD:main Jan 7, 2025
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jumerckx @wsmoses