feat: Stabilize Deno.TcpConn.setNoDelay() and Deno.TcpConn.setKeepAli…

…ve() (denoland#17003) This commit stabilizes following APIs: - `Deno.TcpConn.setNoDelay()` - `Deno.TcpConn.setKeepAlive()`
DavidDeSimone · Dec 13, 2022 · f9db129 · f9db129
1 parent 392cca8
commit f9db129
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 18 deletions.
diff --git a/ext/net/01_net.js b/ext/net/01_net.js
@@ -100,12 +100,12 @@
   }
 
   class TcpConn extends Conn {
-    setNoDelay(nodelay = true) {
-      return ops.op_set_nodelay(this.rid, nodelay);
+    setNoDelay(noDelay = true) {
+      return ops.op_set_nodelay(this.rid, noDelay);
     }
 
-    setKeepAlive(keepalive = true) {
-      return ops.op_set_keepalive(this.rid, keepalive);
+    setKeepAlive(keepAlive = true) {
+      return ops.op_set_keepalive(this.rid, keepAlive);
     }
   }
 

diff --git a/ext/net/lib.deno_net.d.ts b/ext/net/lib.deno_net.d.ts
@@ -185,19 +185,13 @@ declare namespace Deno {
   /** @category Network */
   export interface TcpConn extends Conn {
     /**
-     * **UNSTABLE**: new API, see https://github.com/denoland/deno/issues/13617.
-     *
      * Enable/disable the use of Nagle's algorithm.
      *
-     * @param [nodelay=true]
-     */
-    setNoDelay(nodelay?: boolean): void;
-    /**
-     * **UNSTABLE**: new API, see https://github.com/denoland/deno/issues/13617.
-     *
-     * Enable/disable keep-alive functionality.
+     * @param [noDelay=true]
      */
-    setKeepAlive(keepalive?: boolean): void;
+    setNoDelay(noDelay?: boolean): void;
+    /** Enable/disable keep-alive functionality. */
+    setKeepAlive(keepAlive?: boolean): void;
   }
 
   /** @category Network */

diff --git a/ext/net/ops.rs b/ext/net/ops.rs
@@ -514,7 +514,6 @@ pub fn op_set_nodelay(
   rid: ResourceId,
   nodelay: bool,
 ) -> Result<(), AnyError> {
-  super::check_unstable(state, "Deno.Conn#setNoDelay");
   let resource: Rc<TcpStreamResource> =
     state.resource_table.get::<TcpStreamResource>(rid)?;
   resource.set_nodelay(nodelay)
@@ -526,7 +525,6 @@ pub fn op_set_keepalive(
   rid: ResourceId,
   keepalive: bool,
 ) -> Result<(), AnyError> {
-  super::check_unstable(state, "Deno.Conn#setKeepAlive");
   let resource: Rc<TcpStreamResource> =
     state.resource_table.get::<TcpStreamResource>(rid)?;
   resource.set_keepalive(keepalive)

diff --git a/ops/optimizer_tests/unit_result2.out b/ops/optimizer_tests/unit_result2.out
@@ -36,7 +36,6 @@ impl op_set_nodelay {
         rid: ResourceId,
         nodelay: bool,
     ) -> Result<(), AnyError> {
-        super::check_unstable(state, "Deno.Conn#setNoDelay");
         let resource: Rc<TcpStreamResource> = state
             .resource_table
             .get::<TcpStreamResource>(rid)?;

diff --git a/ops/optimizer_tests/unit_result2.rs b/ops/optimizer_tests/unit_result2.rs
@@ -3,7 +3,6 @@ pub fn op_set_nodelay(
   rid: ResourceId,
   nodelay: bool,
 ) -> Result<(), AnyError> {
-  super::check_unstable(state, "Deno.Conn#setNoDelay");
   let resource: Rc<TcpStreamResource> =
     state.resource_table.get::<TcpStreamResource>(rid)?;
   resource.set_nodelay(nodelay)