Skip to content

Commit

Permalink
refactor(core): make borrow_mut more explicit in the ops macro (den…
Browse files Browse the repository at this point in the history
  • Loading branch information
MarinPostma authored Oct 16, 2022
1 parent 40009eb commit 07213de
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ops/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ fn opstate_arg(arg: &FnArg) -> Option<TokenStream2> {
match arg {
arg if is_rc_refcell_opstate(arg) => Some(quote! { ctx.state.clone(), }),
arg if is_mut_ref_opstate(arg) => {
Some(quote! { &mut ctx.state.borrow_mut(), })
Some(quote! { &mut std::cell::RefCell::borrow_mut(&ctx.state), })
}
_ => None,
}
Expand Down Expand Up @@ -439,7 +439,7 @@ fn codegen_fast_impl(
&*(#core::v8::Local::<#core::v8::External>::cast(data).value()
as *const #core::_ops::OpCtx)
};
let #op_state_name = &mut ctx.state.borrow_mut();
let #op_state_name = &mut std::cell::RefCell::borrow_mut(&ctx.state);
}
} else {
quote! {}
Expand Down Expand Up @@ -542,7 +542,7 @@ fn codegen_v8_sync(
let fast_error_handler = if has_fallible_fast_call {
quote! {
{
let op_state = &mut ctx.state.borrow_mut();
let op_state = &mut std::cell::RefCell::borrow_mut(&ctx.state);
if let Some(err) = op_state.last_fast_op_error.take() {
let exception = #core::error::to_v8_error(scope, op_state.get_error_class_fn, &err);
scope.throw_exception(exception);
Expand Down

0 comments on commit 07213de

Please sign in to comment.