feat: Stabilize Deno.osRelease() API (denoland#15973)

Closes denoland#15928
DavidDeSimone · Oct 26, 2022 · 046ab7d · 046ab7d
1 parent 851db03
commit 046ab7d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 18 deletions.
diff --git a/cli/dts/lib.deno.ns.d.ts b/cli/dts/lib.deno.ns.d.ts
@@ -344,6 +344,22 @@ declare namespace Deno {
    */
   export const noColor: boolean;
 
+  /**
+   * Returns the release version of the Operating System.
+   *
+   * ```ts
+   * console.log(Deno.osRelease());
+   * ```
+   *
+   * Requires `allow-env` permission.
+   * Under consideration to possibly move to Deno.build or Deno.versions and if
+   * it should depend sys-info, which may not be desirable.
+   *
+   * @tags allow-env
+   * @category Runtime Environment
+   */
+  export function osRelease(): string;
+
   /**
    * Options which define the permissions within a test or worker context.
    *

diff --git a/cli/dts/lib.deno.unstable.d.ts b/cli/dts/lib.deno.unstable.d.ts
@@ -226,23 +226,6 @@ declare namespace Deno {
    */
   export function umask(mask?: number): number;
 
-  /** **UNSTABLE**: New API, yet to be vetted.
-   *
-   * Returns the release version of the Operating System.
-   *
-   * ```ts
-   * console.log(Deno.osRelease());
-   * ```
-   *
-   * Requires `allow-sys` permission.
-   * Under consideration to possibly move to Deno.build or Deno.versions and if
-   * it should depend sys-info, which may not be desirable.
-   *
-   * @tags allow-sys
-   * @category Runtime Environment
-   */
-  export function osRelease(): string;
-
   /** **UNSTABLE**: New API, yet to be vetted.
    *
    * Displays the total amount of free and used physical and swap memory in the

diff --git a/runtime/ops/os.rs b/runtime/ops/os.rs
@@ -182,7 +182,6 @@ fn op_hostname(state: &mut OpState) -> Result<String, AnyError> {
 
 #[op]
 fn op_os_release(state: &mut OpState) -> Result<String, AnyError> {
-  super::check_unstable(state, "Deno.osRelease");
   state
     .borrow_mut::<Permissions>()
     .sys
-Original file line number
+Diff line change
@@ Expand Up @@
     #[op]
     fn op_os_release(state: &mut OpState) -> Result<String, AnyError> {
-      super::check_unstable(state, "Deno.osRelease");
       state
         .borrow_mut::<Permissions>()
         .sys
@@ Expand Down @@