Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strong name for ClickHouse.Client. Note: did not include netcoreapp31 and net5. #424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ClickHouse.Client.Tests/ClickHouse.Client.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
<TargetFrameworks>net6.0</TargetFrameworks>
<IsPackable>false</IsPackable>
<LangVersion>latest</LangVersion>

<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>../ClickHouse.Client.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup>
Expand Down
Binary file added ClickHouse.Client.snk
Binary file not shown.
18 changes: 14 additions & 4 deletions ClickHouse.Client/ClickHouse.Client.csproj
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net462;net48;netstandard2.1;netcoreapp3.1;net5.0;net6.0</TargetFrameworks>
<TargetFrameworks>net462;net48;netstandard2.1;net6.0</TargetFrameworks>
<CheckEolTargetFramework>false</CheckEolTargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageProjectUrl>https://github.com/DarkWanderer/ClickHouse.Client</PackageProjectUrl>
<RepositoryUrl>https://github.com/DarkWanderer/ClickHouse.Client</RepositoryUrl>
<RepositoryUrl>https://github.com/osigurdson/ClickHouse.Client</RepositoryUrl>
<PackageTags>clickhouse, ado.net, client</PackageTags>
<Authors>Oleg Kozlyuk</Authors>
<Description>Fast binary-over-HTTP ADO.NET provider for ClickHouse</Description>
Expand All @@ -17,6 +16,11 @@
<LangVersion>latest</LangVersion>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
<AnalysisMode>Recommended</AnalysisMode>

<Version>6.8.2</Version>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>../ClickHouse.Client.snk</AssemblyOriginatorKeyFile>

</PropertyGroup>

<ItemGroup>
Expand All @@ -39,4 +43,10 @@
<Reference Include="System.Web" />
</ItemGroup>

<ItemGroup>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>$(AssemblyName).Tests, PublicKey=00240000048000009400000006020000002400005253413100040000010001009d5a5b1b859c0d137c299e675662b0ff520837448d3ef1e9e77d6908eeaefbf173a62ee8c4b36681b66719a1954d5f7363eb596e5356151e4ee0e8cfe65e9e8793b97b5c8b898ee79b8d7a367017b1e500502b415e938801d3ebe6d2bcffce5bc414aa93bd05dd5aa8c26b453f7621871ebbf6cc1554b88c442671cefd96fb9e</_Parameter1>
</AssemblyAttribute>
</ItemGroup>

</Project>
3 changes: 0 additions & 3 deletions ClickHouse.Client/Types/TypeConverter.cs
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Runtime.CompilerServices;
using ClickHouse.Client.Numerics;
using ClickHouse.Client.Types.Grammar;

[assembly: InternalsVisibleTo("ClickHouse.Client.Tests")] // assembly-level tag to expose below classes to tests

namespace ClickHouse.Client.Types;

internal static class TypeConverter
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# ClickHouse.Client

Clone of https://github.com/ClickHouse/ClickHouse with strong name added. Removed netcoreapp31 and net5 removed as build targets as so many warnings were associated with this.

ADO.NET client for [ClickHouse](https://github.com/ClickHouse/ClickHouse), ultra-fast 'big data' relational database

[![Latest version](https://img.shields.io/nuget/v/ClickHouse.Client)](https://www.nuget.org/packages/ClickHouse.Client/)
Expand Down
Loading