Hide dependency warnings

DameNoSupaplex · Mar 9, 2019 · be2ce45 · be2ce45
1 parent 457bd63
commit be2ce45
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -94,7 +94,7 @@ endif()
 
 # MSVC has default flags that CMake doesn't set
 if (MSVC)
-	add_definitions(-DUNICODE -D_UNICODE -D_CRT_SECURE_NO_WARNINGS)
+	add_definitions(-DUNICODE -D_UNICODE)
 	if (MSVC_VERSION GREATER_EQUAL 1910)
 		set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /permissive-")
 		set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /permissive-")

diff --git a/dependencies/CMakeLists.txt b/dependencies/CMakeLists.txt
@@ -33,6 +33,10 @@ if(NOT WIN32)
 	target_compile_definitions(OpenApoc_LibSmacker PUBLIC PTHREADS_AVAILABLE)
 endif()
 
+if (MSVC)
+	target_compile_definitions(OpenApoc_LibSmacker PRIVATE _CRT_SECURE_NO_WARNINGS)
+endif()
+
 set (MINIZ_SOURCE_FILES
 	miniz/miniz.c
 	miniz/miniz_zip.c
@@ -132,3 +136,10 @@ list(APPEND ALL_HEADER_FILES ${LUA_HEADER_FILES})
 target_include_directories(OpenApoc_Lua PUBLIC ${CMAKE_SOURCE_DIR})
 target_include_directories(OpenApoc_Lua PRIVATE
 		${CMAKE_SOURCE_DIR}/dependencies/lua)
+
+# we don't care about the coding practices of external dependencies
+target_compile_options(OpenApoc_LibSmacker PRIVATE "-w")
+target_compile_options(OpenApoc_LibPugixml PRIVATE "-w")
+target_compile_options(OpenApoc_LibLodepng PRIVATE "-w")
+target_compile_options(OpenApoc_Miniz PRIVATE "-w")
+target_compile_options(OpenApoc_Lua PRIVATE "-w")