Enhancement - Added Color as a filter. #1179
Conversation
|
I noticed that you did all your work on your So far this PR looks good, but I notice that it doesn't take conditional formatting into account, and to do that would anyway be quite difficult. Isn't the use case of colour autofilters indeed to be combined with with conditional formats? Or, in your use case, do you actually want to filter on manually set background colours? |
|
Thanks for the review. |
|
Ok, good work so far. You still need to implement loading and saving of the color autofilter to and from the file. |
|
If I am getting it correctly, then I think saving has been done in ClosedXML_Examples/AutoFilters/ColouredAutoFilter.cs and loading was done inside ClosedXML_Tests/Examples/AutoFilterTests.cs |
|
@igitur - Did you get a chance to look into my comments? |
…et based on the color of your choice.
|
@pranav700 could you please mark this checkbox in this PR: I will push some formatting changes and then it will be ready to be included in 0.96. |
|
@Pankraty - Done, thanks |
igitur
left a comment
igitur
left a comment
There was a problem hiding this comment.
Sorry, I approved too soon. This PR just hides or shows lines depending on the color filter. What's still needed, is to load and save the actual filter from the file.
The file that the test case produces currently looks like this:
But should look like this:
3 participants
What's this PR do? - Now you can filter the worksheet based on the color of your choice.
Where should the reviewer start? - Commit 349cf18
How should this be manually tested? - I think by visually checking input and output files
Any background context you want to provide? - ClosedXML does not have any feature which supports color based filtering. This PR is being proposed to enhance the capability of the solution
Screenshots (if appropriate)
Questions:
Is there a blog post?
Does the knowledge base need an update? -Yes
Does this add new (C#) dependencies?
C# Code Review: @csreviewer
Test Automation Review: @csreviewer