Expose syntheticNamedExports to ModuleInfo #3847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amareis
commented
Oct 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
==========================================
- Coverage 97.06% 97.06% -0.01%
==========================================
Files 184 184
Lines 6518 6517 -1
Branches 1887 1887
==========================================
- Hits 6327 6326 -1
Misses 101 101
Partials 90 90
Continue to review full report at Codecov.
|
lukastaegert
requested changes
Oct 31, 2020
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks! I would consider aligning the handling of the property with moduleSideEffects and meta, though.
lukastaegert
approved these changes
Nov 2, 2020
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
In docs there is line about
metaandsyntheticNamedExportsinModuleInfo: