Watch: listen for new files #3812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3812 +/- ##
=========================================
Coverage ? 97.03%
=========================================
Files ? 185
Lines ? 6477
Branches ? 1876
=========================================
Hits ? 6285
Misses ? 101
Partials ? 91
Continue to review full report at Codecov.
|
lukastaegert
approved these changes
Oct 8, 2020
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Awesome work, thanks a lot! Will release this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
#3704
Description
As suggested in the linked issue.
After I added the second test I discovered that it passes without this patch as well but decided to keep it to be sure.