add ability to specify stdin file extension via --stdin=ext #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3775 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 185 185
Lines 6465 6466 +1
Branches 1874 1875 +1
=======================================
+ Hits 6273 6274 +1
Misses 101 101
Partials 91 91
Continue to review full report at Codecov.
|
Contributor
Author
|
The code coverage failure seems rather insignificant - a partial miss in one line. @lukastaegert Feel free to take over this PR to change its testing and implementation as you see fit. It works fine my own use. I think others could benefit from this new functionality as well. |
Contributor
Author
|
The code was simplified and coverage now passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Addresses missing functionality mentioned in #3312.
Description
Presently rollup can only process
esmvia stdin. This PR adds the ability to specify the CLI stdin file extension via--stdin=extallowing other inputs such as JSON:A synthetic file name
"-.ext"is used internally to represent the stdin filename with an extension in order to work with existing plugins with suffix-based logic. Stdin based input can still be disabled with--no-stdinif required.Unfortunately this new stdin extension feature will not work with plugins that interrogate the filesystem to read input files such as
@rollup/plugin-typescript. For this scenario other plugins like@rollup/plugin-sucraseorrollup-plugin-esbuildcould be used instead.