Docs: Exception for babel plugin and commonjs plugin #3770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3770 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 185 185
Lines 6460 6460
Branches 1870 1870
=======================================
Hits 6268 6268
Misses 101 101
Partials 91 91 Continue to review full report at Codecov.
|
lukastaegert
approved these changes
Sep 16, 2020
Member
lukastaegert
left a comment
lukastaegert
left a comment
There was a problem hiding this comment.
Thanks. I still think the note is helpful and much more correct with your correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
rollup/rollup-plugin-commonjs #247
Description
Due to the previous listed issue and resolution; current documentation was inaccurate. This fixes the issue with Babel specifically, although I'm not sure if the "Note" should exist at all 🤔