Skip to content

[ts] Disallow invalid type annotations in ExpressionStatements #12185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 1 commit into from
Oct 16, 2020
Merged

[ts] Disallow invalid type annotations in ExpressionStatements #12185

nicolo-ribaudo merged 1 commit into from
Oct 16, 2020

Conversation

@existentialism
Copy link
Member

@existentialism existentialism commented Oct 15, 2020 •
edited by JLHwung
Loading

Q                       A
Fixed Issues? Fixes #12180
Patch: Bug Fix? Y
License MIT

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Oct 15, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 847fffd:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title Fix regression with invalid type annotations in ExpressionStatements [ts] Disallow invalid type annotations in ExpressionStatements Oct 16, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 47250ff into main Oct 16, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the type-cast-expr-agane branch October 16, 2020 08:20
@thorn0 thorn0 mentioned this pull request Oct 16, 2020
Merged
3 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ts]No syntax error is thrown for invalid type annotation

4 participants

@existentialism @JLHwung @nicolo-ribaudo